[PATCH] D61560: [TargetLowering] Handle multi depth GEPs w/ inline asm constraints

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers marked 2 inline comments as done.
nickdesaulniers added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp:3494
+      if ((GA = dyn_cast<GlobalAddressSDNode>(Op)) && ConstraintLetter != 'n') {
+        Ops.push_back(DAG.getTargetGlobalAddress(GA->getGlobal(), SDLoc(Op),
+                                                 GA->getValueType(0),
----------------
Maybe I should initialize `C` to `nullptr` and then keep the `C ? SDLoc(C) : SDLoc()`?  I'm not verify familiar with `SDLoc`, but it seems that I'm potentially messing up debug info?  Should the previous code be constructing empty `SDLoc`s (as opposed to `SDLoc(GA)`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61560/new/

https://reviews.llvm.org/D61560