[PATCH] D61646: Include corecrt.h/vcruntime.h to improve MS compatibility

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 8 14:41:48 PDT 2019


phosek added a comment.

This change broke our build which is using Clang and the `x86_64-windows-msvc` target to cross-compile our EFI bootloader. Now the compilation fails <https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket.appspot.com/8913996720033157664/+/steps/build/0/steps/build_fuchsia/0/steps/ninja/0/steps/zircon/0/stdout> because it cannot find Windows headers (as expected).  We're probably going to work around the issue by setting `-U_MSC_VER`, but I'm going to start a discussion whether we should maybe define a new target for EFI.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61646/new/

https://reviews.llvm.org/D61646





More information about the llvm-commits mailing list