[PATCH] D59272: [DebugInfo] Select debug intrinsic line-numbers more carefully when promoting dbg.declare

[Jeremy Morse via Phabricator via llvm-commits]

jmorse updated this revision to Diff 198638.
jmorse added a comment.

Add comment explaining the choice of zero line numbers in getDebugValueLoc. After discussion in D61198 <https://reviews.llvm.org/D61198>, I've removed the clause preserving the line numbers of store instructions -- It's probably better to make it clear that the line number information in debug intrinsics is completely meaningless, and thus not try to preserve it at all. The selection of a zero line number is thus just a defence against leaky optimisations.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59272/new/

https://reviews.llvm.org/D59272

Files:
  lib/Transforms/Utils/Local.cpp
  test/DebugInfo/Generic/dbg-value-lower-linenos.ll
  test/DebugInfo/X86/formal_parameter.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D59272.198638.patch
Type: text/x-patch
Size: 9700 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190508/29b7fb45/attachment.bin>