[PATCH] D61676: [MCA] Add support for nested and overlapping region markers

[Andrea Di Biagio via Phabricator via llvm-commits]

andreadb created this revision.
andreadb added reviewers: RKSimon, courbet, craig.topper, mattd, lebedev.ri.
Herald added a subscriber: gbedwell.

This patch fixes PR41523
https://bugs.llvm.org/show_bug.cgi?id=41523

Regions can now nest/overlap provided that they have different names.
Anonymous regions cannot overlap.

Region end markers must specify the region name. The only exception is for when there is only one user-defined region; in that particular case, the region end marker doesn't need to specify a name.

Incorrect region end markers are no longer ignored. Instead, the tool reports an error and we exit with an error code.

Added test cases to verify the new diagnostic error messages.

Updated the llvm-mca docs to reflect this feature change.

Let me know if okay to commit.

Thanks,
Andrea


https://reviews.llvm.org/D61676

Files:
  docs/CommandGuide/llvm-mca.rst
  test/tools/llvm-mca/X86/llvm-mca-markers-10.s
  test/tools/llvm-mca/X86/llvm-mca-markers-11.s
  test/tools/llvm-mca/X86/llvm-mca-markers-12.s
  test/tools/llvm-mca/X86/llvm-mca-markers-6.s
  test/tools/llvm-mca/X86/llvm-mca-markers-7.s
  test/tools/llvm-mca/X86/llvm-mca-markers-8.s
  test/tools/llvm-mca/X86/llvm-mca-markers-9.s
  tools/llvm-mca/CodeRegion.cpp
  tools/llvm-mca/CodeRegion.h
  tools/llvm-mca/CodeRegionGenerator.cpp
  tools/llvm-mca/llvm-mca.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D61676.198634.patch
Type: text/x-patch
Size: 21277 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190508/7182a064/attachment.bin>