[PATCH] D61020: [ARM][ParallelDSP] Relax alias checks

Wed May 8 04:49:49 PDT 2019

samparker marked an inline comment as done.
samparker added inline comments.

================
Comment at: lib/Target/ARM/ARMParallelDSP.cpp:369
+    if (WARDeps.count(Dominator) && RAWDeps.count(Dominated)) {
+      InstSet &WARs = WARDeps[Dominator];
+      InstSet &RAWs = RAWDeps[Dominated];
----------------
SjoerdMeijer wrote:
> I think I am struggling with the algorithm here. Here, and in the line below, we get the "write sets" of the 2 loads. We then start iterating over them , and if a write does not occur in both sets then we say it is safe to pair. But is this enough?
Good point! No... we also need to check that it's possible to either move the first load forward or the second load backward.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61020/new/

https://reviews.llvm.org/D61020