[PATCH] D61660: [cmake] Make google benchmark project call llvm_add_library

Don Hinton via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 7 16:02:41 PDT 2019


hintonda created this revision.
hintonda added a reviewer: beanz.
Herald added subscribers: lebedev.ri, mgorny.
Herald added a reviewer: lebedev.ri.
Herald added a project: LLVM.

This gets rid of a warning on MacOS when compiled with
BUILD_SHARED_LIBS=ON.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D61660

Files:
  llvm/utils/benchmark/src/CMakeLists.txt


Index: llvm/utils/benchmark/src/CMakeLists.txt
===================================================================
--- llvm/utils/benchmark/src/CMakeLists.txt
+++ llvm/utils/benchmark/src/CMakeLists.txt
@@ -16,7 +16,7 @@
   list(REMOVE_ITEM SOURCE_FILES "${item}")
 endforeach()
 
-add_library(benchmark ${SOURCE_FILES})
+llvm_add_library(benchmark ${SOURCE_FILES})
 set_target_properties(benchmark PROPERTIES
   OUTPUT_NAME "benchmark"
   VERSION ${GENERIC_LIB_VERSION}
@@ -45,7 +45,7 @@
 endif()
 
 # Benchmark main library
-add_library(benchmark_main "benchmark_main.cc")
+llvm_add_library(benchmark_main "benchmark_main.cc")
 set_target_properties(benchmark_main PROPERTIES
   OUTPUT_NAME "benchmark_main"
   VERSION ${GENERIC_LIB_VERSION}


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D61660.198557.patch
Type: text/x-patch
Size: 744 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190507/f7b38037/attachment.bin>


More information about the llvm-commits mailing list