[PATCH] D61390: [CodeGen] Add lround/llround builtins

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:2166
+
+  return ExpandLibCall(LC, Node, true);
+}
----------------
Doesn't ExpandFPLibCall pass false for the last argument? We should probably do the same here.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:2491
+  EVT RetVT = N->getValueType(0);
+  SplitInteger(TLI.makeLibCall(DAG, LC, RetVT, Op, true, dl).first, Lo, Hi);
+}
----------------
Mark that bool flag as irrelevant like ExpandIntRes_FP_TO_UINT and ExpandIntRes_FP_TO_SINT?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61390/new/

https://reviews.llvm.org/D61390