[PATCH] D61599: [Support] MemoryBlock objects now expose their allocated size in addition to the requested size.

Machiel van Hooren via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 7 12:17:41 PDT 2019


mvhooren added a comment.

In D61599#1493889 <https://reviews.llvm.org/D61599#1493889>, @lhames wrote:

> I don't think this is the right solution. MemoryBlock's purpose is to track the allocated memory. What the client does with that memory (including subdividing it) is their business. The client already knows the number of bytes they're requesting, so the fix for fragmentation in SectionMemoryManager should be limited to fixes in SectionMemoryManager.


Yes I agree it would be better if the Size member of MemoryBlock just held the allocated size. This would mean that r357058 and r351916 (and perhaps others) should be reverted.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61599/new/

https://reviews.llvm.org/D61599





More information about the llvm-commits mailing list