[PATCH] D61632: Revert "[TableGen] Fix a typo"

Krasimir Georgiev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 7 01:57:46 PDT 2019


krasimir created this revision.
Herald added subscribers: llvm-commits, PkmX.
Herald added a project: LLVM.

This reverts commit r360106.

The revisioin causes llvm-tblgen to hang while generating info for
RISCV.td. The root cause might be in the RISCV.td definition but I don't
know enough about this to investigate further.

Command that starts hangning after r360106:
`llvm-build/bin/llvm-tblgen -I llvm/include -I llvm/tools/clang/include -I llvm/lib/Target/RISCV -gen-instr-info llvm/lib/Target/RISCV/RISCV.td`


Repository:
  rL LLVM

https://reviews.llvm.org/D61632

Files:
  utils/TableGen/CodeGenDAGPatterns.cpp


Index: utils/TableGen/CodeGenDAGPatterns.cpp
===================================================================
--- utils/TableGen/CodeGenDAGPatterns.cpp
+++ utils/TableGen/CodeGenDAGPatterns.cpp
@@ -479,7 +479,7 @@
     TypeSetByHwMode::SetType &S = Small.get(M);
     TypeSetByHwMode::SetType &B = Big.get(M);
 
-    if (any_of(S, isIntegerOrPtr) && any_of(B, isIntegerOrPtr)) {
+    if (any_of(S, isIntegerOrPtr) && any_of(S, isIntegerOrPtr)) {
       auto NotInt = [](MVT VT) { return !isIntegerOrPtr(VT); };
       Changed |= berase_if(S, NotInt) |
                  berase_if(B, NotInt);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D61632.198412.patch
Type: text/x-patch
Size: 595 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190507/16663abf/attachment.bin>


More information about the llvm-commits mailing list