[PATCH] D61610: [PPC64] implement Thunk Section Spacing

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 6 22:33:25 PDT 2019


ruiu added inline comments.


================
Comment at: lld/ELF/Arch/PPC64.cpp:930
+uint32_t PPC64::getThunkSectionSpacing() const {
+  // REL14 range
+  return 0x8000;
----------------
Could you extend the comment a bit to make it a complete sentence explaining what this value means. I'd say we create initial thunks at regular spacing so that most relocations reach the thunks. On PPC64, REL14 (whose offset is 0x8000) is the most strict relocation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61610/new/

https://reviews.llvm.org/D61610





More information about the llvm-commits mailing list