[PATCH] D61586: [mips] fix segment fault for plt on mips64.

Qiao Pengcheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 6 18:13:47 PDT 2019


QiaoPengcheng marked an inline comment as done.
QiaoPengcheng added a comment.

In D61586#1491724 <https://reviews.llvm.org/D61586#1491724>, @atanasyan wrote:

> Good catch, thanks. BTW on what OS do you get this problem? PLT records on MIPS 64-bit code are not widely used.


My OS is mips64el-fedora  desktop-PC.
Our company is loongson, a CPU-processor-design company in China.
And our company are now pupulating the mips64el-linux-desktop in China quickly.

> Please add test case for the patch. Probably we can split the `lld/test/ELF/mips-26-n32-n64.s` into N32 and N64 variants.

I will upload later.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61586/new/

https://reviews.llvm.org/D61586





More information about the llvm-commits mailing list