[PATCH] D61105: [MS] Emit S_HEAPALLOCSITE debug info in SelectionDAG

Amy Huang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 6 16:28:46 PDT 2019


akhuang added a comment.

I made some changes to keep the MDNodeSDNode attached to the call, which I mostly did by adding some special cases when operands are MDNodeSDNodes. Since call operands are currently all registers, it seems like it would be less invasive to use a map than to change the convention to include this specific MDNodeSDNode as an operand.

We also want the metadata to be dropped during tail call optimization, which would require some extra work to do here, but works with the map since the call gets replaced there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61105/new/

https://reviews.llvm.org/D61105





More information about the llvm-commits mailing list