[PATCH] D60385: FileCheck [5/12]: Introduce regular numeric variables

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

Nearly there!  One final grammar nit and some test comments.

For defines.txt/pattern-defines.txt, please do the reorganization of the RUN lines as a separate NFC commit first, so then we can better see the functional difference that goes with this patch.  Right now it's very hard to follow.



================
Comment at: llvm/include/llvm/Support/FileCheck.h:156
+  /// instance or None if substitution failed. Numeric expression are
+  /// substituted by their value. Pattern variables are simply replaced by the
+  /// text their definition matched.
----------------
expression -> expressions
value -> values

(to be grammatically consistent with the next sentence)


================
Comment at: llvm/test/FileCheck/var-scope.txt:8
+// RUN: not FileCheck -D#LOCNUM=1 -D#$GLOBNUM=1 -check-prefixes CHECK,LOCAL3 --enable-var-scope -input-file %s %s
+
+local1
----------------
Is there a different test that validates the diagnostic for using an undefined local?  All this test does is verify that FileCheck returns nonzero.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60385/new/

https://reviews.llvm.org/D60385