[PATCH] D61574: [CommandLine] Allow Options to specify multiple OptionCategory's.

Don Hinton via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 6 14:12:48 PDT 2019


hintonda added a comment.

In D61574#1492410 <https://reviews.llvm.org/D61574#1492410>, @hintonda wrote:

> In D61574#1491484 <https://reviews.llvm.org/D61574#1491484>, @hintonda wrote:
>
> > In D61574#1491471 <https://reviews.llvm.org/D61574#1491471>, @MaskRay wrote:
> >
> > > May I ask you to share some dumps of `some-command -help` (a demo how you'll make use of the multiple categories)😁
> >
> >
> > Sure, I work up an example.  Btw, my ultimate plan is to add categories to the passes so that bugpoint help isn't just a huge mess.  That's the motivation for this change.  When I started adding them, I found it wasn't really doable without this change since so many passes shared options.
>
>
> There's currently not clean way to do this without being able to capture stdout when calling ParseCommandLineOptions, so I'll add that in a separate patch for that and use it here.  Please see D30893 <https://reviews.llvm.org/D30893> for something similar that was done to capture stderr.


After looking into it, I'm not going to try to capture stdout.  So, I'm not going to add a test that compares help output.  This is consistent with the status quo -- there isn't a test for that in llvm.  I suppose I could add one to clang since I'd have access to `%clang` in lit, but adding an llvm test to clang seems a bit odd.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61574/new/

https://reviews.llvm.org/D61574





More information about the llvm-commits mailing list