[PATCH] D61510: [SanitizerCoverage] Use different module ctor names for trace-pc-guard and inline-8bit-counters

Roland McGrath via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 6 11:58:49 PDT 2019


mcgrathr added a comment.

Previously the same local symbol name was being used for both things in an uncoordinated fashion.  The logic in places like ValueSymbolTable::createValueName leads to the second one getting renamed with some ".digits" suffix to make them unique.
Then the code that emits the references between the init_array and the actual function and sets the COMDAT group name assumed it could use the original name throughout, but in some places this was replaced with the suffixed name and in some places it was not, leading to the incorrect references.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61510/new/

https://reviews.llvm.org/D61510





More information about the llvm-commits mailing list