[PATCH] D61582: [SelectionDAG][X86] Support inline assembly returning an mmx register into a type with fewer than 64 bits.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 6 08:38:47 PDT 2019


RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM as a stopgap



================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:329
+      ValueVT.bitsLT(PartEVT)) {
+    PartEVT = EVT::getIntegerVT(*DAG.getContext(),  PartEVT.getSizeInBits());
+    Val = DAG.getNode(ISD::BITCAST, DL, PartEVT, Val);
----------------
extra whitespace but is it worth just using MVT::i64?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61582/new/

https://reviews.llvm.org/D61582





More information about the llvm-commits mailing list