[PATCH] D61595: [SIMode] Fix typo in Status constructor

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 6 07:38:52 PDT 2019


RKSimon marked an inline comment as done.
RKSimon added inline comments.


================
Comment at: lib/Target/AMDGPU/SIModeRegister.cpp:47
 
-  Status(unsigned Mask, unsigned Mode) : Mask(Mask), Mode(Mode) {
+  Status(unsigned _Mask, unsigned _Mode) : Mask(_Mask), Mode(_Mode) {
     Mode &= Mask;
----------------
arsenm wrote:
> Should use something other than a leading underscore to disambiguate
No problem, its up to you - an alternative would be to write:
```
this->Mode &= this->Mask.
```


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61595/new/

https://reviews.llvm.org/D61595





More information about the llvm-commits mailing list