[PATCH] D61511: [DAGCombiner] Limit number of nodes explored as store candidates.

[Nirav Dave via Phabricator via llvm-commits]

niravd added a comment.

This is okay modulo nits, but let's land the TokenFactor operand size limiting first as it also implicitly bounds things.



================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:14845
+    for (auto I = RootNode->use_begin(), E = RootNode->use_end();
+         I != E && NumNodesExplored < 1024; ++I, NumNodesExplored++)
       if (I.getOperandNo() == 0 && isa<LoadSDNode>(*I)) // walk down chain
----------------
nit: use prefix increment to be consistent with other uses.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:14857
+    for (auto I = RootNode->use_begin(), E = RootNode->use_end();
+         I != E && NumNodesExplored < 1024; ++I, NumNodesExplored++)
       if (I.getOperandNo() == 0)
----------------
nit: same



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61511/new/

https://reviews.llvm.org/D61511