[PATCH] D61564: [AMDGPU] Check MI bundles for hazards

Austin Kerbow via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 5 13:12:53 PDT 2019


kerbowa marked 2 inline comments as done.
kerbowa added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:1172
+  DebugLoc DL = MBB.findDebugLoc(MI);
+  while (Count > 0) {
+    int Arg;
----------------
rampitec wrote:
> I do not like code duplication here. Can you call one from another?
At first glance having the standard insertWaitStates call the instr_iterator version seems to break a bunch of tests. I can just add a function to insert noop's in bundles in GCNHazardRecognizer instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61564/new/

https://reviews.llvm.org/D61564





More information about the llvm-commits mailing list