[PATCH] D61557: [X86] Add more one checks to masked compare patterns that were missed in r358358.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat May 4 21:02:32 PDT 2019


craig.topper created this revision.
craig.topper added reviewers: spatel, dblaikie, RKSimon.
Herald added a subscriber: hiraditya.
Herald added a project: LLVM.
craig.topper abandoned this revision.
craig.topper added a comment.

Apparently I had two uncommitted patches in my tree. I didn't mean them to combine like this


This covers the patterns we use for widening 128/256 comparisons to 512-bit when
AVX512VL isn't supported.

[Constants] Simplify type checking switch in ConstantExpr::get.

Remove duplicate checks that both operands have the same type. This is checked
before the switch.

Use 'integer' or 'floating-point' instead of 'arithmetic' type. I think this
might be a leftover to the days when floating point and integer operations
shared the same opcodes.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D61557

Files:
  llvm/lib/IR/Constants.cpp
  llvm/lib/Target/X86/X86InstrAVX512.td

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D61557.198156.patch
Type: text/x-patch
Size: 14289 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190505/094ce8fe/attachment.bin>


More information about the llvm-commits mailing list