[PATCH] D58311: [MemorySSA & LoopPassManager] Enable MemorySSA as loop dependency. Update tests.

[Chandler Carruth via Phabricator via llvm-commits]

chandlerc added a comment.

One question about a test change and a minor nit pick on comments...



================
Comment at: test/Analysis/BasicAA/store-promote.ll:32
 ; CHECK:      Out:
-; CHECK:        store i32 %Atmp, i32* @B
+; CHECK:        load i32, i32* @A
 }
----------------
Is this actually an additional load? Or was it always there before but the test just didn't have a `CHECK` line for it?


================
Comment at: test/Transforms/LICM/argmemonly-call.ll:96
 ; argmemonly bar call out of the loop.
-; Using MemorySSA we can also hoist bar.
+; Using MemorySSA we can also hoist bar. Test updated with flag flipped.
 
----------------
No need for the extra comment here IMO... Comments should just document the current state, not transitions.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58311/new/

https://reviews.llvm.org/D58311