[PATCH] D61551: [llvm-nm] Fix handling of symbol types 't' 'd' 'r'

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat May 4 03:17:21 PDT 2019


MaskRay created this revision.
MaskRay added reviewers: rupprecht, jhenderson.
Herald added subscribers: llvm-commits, dexonsmith, steven_wu, eraman, mehdi_amini.
Herald added a project: LLVM.

This restores part of r359311 that was reverted by r359830.

Rewrite the symbol types to fix several issues.

Notable difference is that the type of __init_array_start changes from
't' to 'd'.

GNU nm used to mark ELF symbols relative to .init_array as 't'
https://sourceware.org/bugzilla/show_bug.cgi?id=24505 (before 2.33)
because ".init" is the prefix. The bug was copied by r287803.


Repository:
  rL LLVM

https://reviews.llvm.org/D61551

Files:
  test/ThinLTO/X86/strong_non_prevailing.ll
  test/tools/llvm-nm/X86/Inputs/init-fini.out.elf-x86_64
  test/tools/llvm-nm/X86/bss.test
  test/tools/llvm-nm/X86/data.test
  test/tools/llvm-nm/X86/init-fini.test
  test/tools/llvm-nm/X86/linker-synthesized.test
  test/tools/llvm-nm/X86/nonalloc.test
  tools/llvm-nm/llvm-nm.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D61551.198133.patch
Type: text/x-patch
Size: 6494 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190504/440d812d/attachment.bin>


More information about the llvm-commits mailing list