[PATCH] D61489: RegAlloc: try to fail more gracefully when out of registers

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 3 08:57:54 PDT 2019


qcolombet added inline comments.


================
Comment at: lib/CodeGen/RegAllocBase.cpp:129
+                ? "inline assembly requires more registers than available"
+                : "ran out of registers during register allocation");
+      } else {
----------------
Although I find the patch sensible, the new behavior is somewhat misleading:
If MI is not an inline asm statement, we are still going to report a source location (if any), whereas unlike inline asm statement, there is little to nothing that the user can do with that information. It could actually be counter productive to give them that location.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61489/new/

https://reviews.llvm.org/D61489





More information about the llvm-commits mailing list