[PATCH] D61435: [AArch64] NFC: Add generic StackOffset to describe scalable offsets.

[Diana Picus via Phabricator via llvm-commits]

rovka added a comment.

I'd also add a unit test for StackOffset.



================
Comment at: lib/Target/AArch64/AArch64StackOffset.h:21
+// describes an offset that spans the combined storage required for an SVE
+// vector and a 64bit GPR.
+//
----------------
Nitpick: This would look better as a class comment. For the file comment you could write something more brief, e.g. "\file This file contains the declaration of the StackOffset class, which is used to describe scalable and non-scalable offsets during frame lowering."


================
Comment at: lib/Target/AArch64/AArch64StackOffset.h:83
+  /// decomposed for the purpose of describing a frame offset.
+  /// For non-scalable offsets this is simple its byte size.
+  void getForFrameOffset(int64_t &ByteSized) const {
----------------
Typo: simply


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61435/new/

https://reviews.llvm.org/D61435