[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

Thu May 2 20:07:38 PDT 2019

Meinersbur added a comment.

Do you intent to use this interface for a specific external project, or is it to avoid direct references to Polly?

This changes a behavior we currently have with Polly: If it is checked out into tools/polly, it was automatically linked into opt, bugpoint, clang.

Are you also uploading a patch for clang?

================
Comment at: tools/CMakeLists.txt:56

+# Also add extension libs not listed in external projetc
+foreach(p ${LLVM_EXTENSION_LIBS})
----------------
[typo] projetc

================
Comment at: tools/bugpoint/CMakeLists.txt:43
-  # Ensure LLVMTarget can resolve dependences in Polly.
-  target_link_libraries(bugpoint PRIVATE LLVMTarget)
-endif(WITH_POLLY AND LINK_POLLY_INTO_TOOLS)
----------------
LLVMTarget is required in some circumstances: Polly-ACCs requires the NVPTX target to be present and its symbols cannot be resolved if not linked into bugpoint.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61446/new/

https://reviews.llvm.org/D61446