[PATCH] D61037: [WebAssembly] Implement ReplaceNodeResults to fix a SIMD crash

[Heejin Ahn via Phabricator via llvm-commits]

aheejin accepted this revision.
aheejin added a comment.
This revision is now accepted and ready to land.

Thanks for investigating this! This is getting kind of hard to understand without knowing the context that why `signext_inreg` is custom lowered for SIMD but actually not custom lowered....



================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:898
+  // Do not add any results, signifying that N should not be custom lowered
+  // after all
+}
----------------
Can we guarantee this function is only executed in case of `SIGN_EXTEND_INREG`? How about checking its opcode here and if not do `llvm_unreachable` or something, with some comments why we need this for `SIGN_EXTEND_INREG`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61037/new/

https://reviews.llvm.org/D61037