[PATCH] D61460: Fix bug in getCompleteTypeIndex in codeview debug info

[Amy Huang via Phabricator via llvm-commits]

akhuang added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:2519-2521
+  auto InsertResult = CompleteTypeIndices.insert({CTy, TypeIndex()});
+  if (!InsertResult.second)
+    return InsertResult.first->second;
----------------
rnk wrote:
> While we're here, please simplify this to just use `.find` since we can't use InsertResult below.
Not inserting breaks in the case of circular references


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61460/new/

https://reviews.llvm.org/D61460