[PATCH] D61437: [AArch64] Static (de)allocation of SVE stack objects.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 2 11:30:13 PDT 2019


efriedma added a comment.

Your proposed stack layout doesn't really make sense.  There are a few issues:

1. How do you compute the address of a stack argument?
2. Under the ios and Windows calling conventions, vararg functions must allocate some fixed slots directly after the stack arguments.
3. How do you restore SP in the epilogue?

It would make a lot more sense to place the SVE objects somewhere between FP and SP; we already support allocating a variable amount of space between FP and SP, for stack realignment.

Not sure what impact this has on this patch; maybe not much?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61437/new/

https://reviews.llvm.org/D61437





More information about the llvm-commits mailing list