[PATCH] D61387: [CMake][benchmark] Cache result of CXXFeatureCheck

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 2 11:11:02 PDT 2019


lebedev.ri added a reviewer: EricWF.
lebedev.ri added a comment.

In D61387#1488279 <https://reviews.llvm.org/D61387#1488279>, @beanz wrote:

> Libc++'s test cases aren't buildable without LLVM. Why should the benchmarks be?


Note that libc++'s `benchmark` predates llvm's `benchmark`,
so if libc++ really doesn't care about building benchmarks in standalone mode,
then i suppose libc++ `benchmark` is the one you want to drop.
But this isn't particularly relevant to this patch, i suppose.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61387/new/

https://reviews.llvm.org/D61387





More information about the llvm-commits mailing list