[PATCH] D60385: FileCheck [5/12]: Introduce regular numeric variables

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre added inline comments.


================
Comment at: llvm/include/llvm/Support/FileCheck.h:76
+
+  /// Return name of that numeric variable.
+  StringRef getName() const { return Name; }
----------------
jhenderson wrote:
> Here and elsewhere, you should probably use the doxygen style for "Return".
I've only done it for those added in this patch. I've created a separate patch for the existing uses, https://reviews.llvm.org/D61445


================
Comment at: llvm/include/llvm/Support/FileCheck.h:319
+  /// patterns:
+  /// - tables with the values of live pattern and numeric variables at
+  ///   the start of any given CHECK line;
----------------
jhenderson wrote:
> tables -> table
There's 2 tables: one for pattern variables and one for numeric variables. I can split into 2 items if you prefer, I didn't because the comment would be mostly redundant.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60385/new/

https://reviews.llvm.org/D60385