[PATCH] D61261: [AMDGPU] Increases available SGPR for Calling Convention

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 2 04:36:36 PDT 2019


arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPUCallingConv.td:35
+    SGPR96, SGPR97, SGPR98, SGPR99, SGPR100, SGPR101, SGPR102, SGPR103,
+    SGPR104
   ]>>>,
----------------
It's up to SGPR105, not 105 SGPRs. SGPR105 should also be included


================
Comment at: lib/Target/AMDGPU/AMDGPUCallingConv.td:40-41
   // here, so use a custom function.
   CCIfInReg<CCIfType<[i64], CCCustom<"allocateSGPRTuple">>>,
   CCIfByVal<CCIfType<[i64], CCCustom<"allocateSGPRTuple">>>,
 
----------------
I think this needs more work. I think allocateSGPRTuple hard codes the limit as well


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61261/new/

https://reviews.llvm.org/D61261





More information about the llvm-commits mailing list