[PATCH] D61377: [llvm-strip]Add --no-strip-all to disable --strip-all behaviour (including default stripping)

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 2 03:37:59 PDT 2019


MaskRay accepted this revision.
MaskRay added inline comments.


================
Comment at: tools/llvm-objcopy/CopyConfig.cpp:722
   Config.StripUnneeded = InputArgs.hasArg(STRIP_strip_unneeded);
-  Config.StripAll = InputArgs.hasArg(STRIP_strip_all);
+  if (auto Arg = InputArgs.getLastArg(STRIP_strip_all, STRIP_no_strip_all))
+    Config.StripAll = Arg->getOption().getID() == STRIP_strip_all;
----------------
Nit. `auto *` is more common, but I see the `auto Arg` below doesn't have the `*`... so you can ignore me.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61377/new/

https://reviews.llvm.org/D61377





More information about the llvm-commits mailing list