[PATCH] D61190: [yaml2obj] - Make interface of `NameToIdxMap` class be human friendly and fix users.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 2 01:47:44 PDT 2019


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: tools/yaml2obj/yaml2elf.cpp:78
   }
-  /// asserts if name is not present in the map
+  /// asserts if name is not present in the map.
   unsigned get(StringRef Name) const {
----------------
grimar wrote:
> jhenderson wrote:
> > As you're tidying this comment up, please change "asserts" to "Asserts".
> Done. And for `Returns` above too.
Not sure if those are necessary or not due to doxygen!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61190/new/

https://reviews.llvm.org/D61190





More information about the llvm-commits mailing list