[PATCH] D61400: [SelectionDAG] Utilize ARM shift behavior

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 1 14:14:20 PDT 2019


nikic added a comment.

I suspect that it's not safe to do this in this form: While the shift instruction on the target might be well defined, this is still operating on ISD opcodes that consider out-of-bounds shifts to be undef. After you have eliminated the check, some other combine could come along and optimize the shift to undef based on that.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61400/new/

https://reviews.llvm.org/D61400





More information about the llvm-commits mailing list