[PATCH] D61312: [llvm-objdump] - Print relocation record in a GNU format.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 1 08:58:40 PDT 2019


grimar added inline comments.


================
Comment at: include/llvm/Object/ObjectFile.h:432
 inline bool SectionRef::operator!=(const SectionRef &Other) const {
+  if (OwningObject != Other.OwningObject)
+    return true;
----------------
MaskRay wrote:
> Just use `&&` for `operator==` and implement `operator!=` in terms of `operator==`?
Yes, that is better. Done.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61312/new/

https://reviews.llvm.org/D61312





More information about the llvm-commits mailing list