[PATCH] D61312: [llvm-objdump] - Print relocation record in a GNU format.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: test/tools/llvm-objdump/relocations-elf.test:78
+# RUN: not llvm-objdump --reloc %t2 2>&1 | FileCheck %s --check-prefix=ERR
+# ERR: LLVM ERROR: Invalid data was encountered while parsing the file
+
----------------
jhenderson wrote:
> This is not a nice error. Can anything be done easily to improve it?
This message is associated with

```
static ManagedStatic<_object_error_category> error_category;

const std::error_category &object::object_category() {
  return *error_category;
}
```

I think more `ErrorOr` in `lib/Object` should migrate to `Expected/Error` to fix this. That improvement is not related to this patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61312/new/

https://reviews.llvm.org/D61312