[PATCH] D61325: Treat a narrowing PtrToInt like Trunc when generating asm

Mat Hostetter via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 30 14:16:33 PDT 2019


mjhostet marked an inline comment as done.
mjhostet added inline comments.


================
Comment at: llvm/test/CodeGen/X86/ptrtoint-narrow.ll:2
+; RUN: llc < %s -mtriple=x86_64-- -filetype=obj
+
+%struct.MyStruct = type { i32 }
----------------
arsenm wrote:
> Needs to check output. Usually for object emission, the disassembled output is checked
Sure, I can check output if you want. The reason I didn't is because previously, llc printed the following error and exited with a error status when its internal assembler failed:

```
fatal error: error in backend: expected relocatable expression
```

The included test is testing that this no longer happens. I'll check the output too.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61325/new/

https://reviews.llvm.org/D61325





More information about the llvm-commits mailing list