[PATCH] D61255: [ThinLTO] Make weak data symbols prevailing when they're visible to regular object

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 30 13:30:06 PDT 2019


tejohnson added a comment.

In D61255#1484855 <https://reviews.llvm.org/D61255#1484855>, @evgeny777 wrote:

> > Maybe using ReadOnly bits in summary
>
> `ReadOnly` can be used only after `computeDeadSymbols` is executed, so IMO not gonna work


We decide what to internalize after computeDeadSymbols, so why wouldn't we be able to use this to block internalization of linkonce_odr global variables (when !ReadOnly)?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61255/new/

https://reviews.llvm.org/D61255





More information about the llvm-commits mailing list