[PATCH] D61331: [SelectionDAG] remove constant folding limitations based on FP exceptions

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 30 11:50:34 PDT 2019


spatel created this revision.
spatel added reviewers: cameron.mcinally, kpn, greened, mcberg2017, efriedma.
Herald added subscribers: aheejin, hiraditya, jgravelle-google, sbc100, javed.absar, nhaehnle, jvesely, mcrosier, dschuff, arsenm.
Herald added a project: LLVM.

We don't have any FP exception limits in the IR constant folder (apart from strict ops), so I don't think it makes sense to have them here in the DAG either. Nothing else in the backend tries to preserve those (again outside of strict ops), so I don't see how this could have ever worked for real code that cares about FP exceptions.


https://reviews.llvm.org/D61331

Files:
  llvm/include/llvm/CodeGen/TargetLowering.h
  llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
  llvm/lib/CodeGen/TargetLoweringBase.cpp
  llvm/lib/Target/AMDGPU/SIISelLowering.cpp
  llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp
  llvm/test/CodeGen/AArch64/fp-const-fold.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D61331.197388.patch
Type: text/x-patch
Size: 8474 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190430/eef80e37/attachment.bin>


More information about the llvm-commits mailing list