[PATCH] D61262: [AArch64] Implement MC support for Scalable Vector Extension 2 (SVE2)

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 30 08:43:05 PDT 2019


SjoerdMeijer added a comment.

I don't have strong opinions on this:

> If I split the above into a separate patch the remaining changes will be TableGen descriptions adding new instructions, along with tests. I understand this will still be a huge patch to review so I could break it down by encoding group (~26) as you suggest if that will make things easier.

This could still be one big bang commit, it's mostly tests (and encodings) and I assume too that people will believe this. But yes, this would be helpful I think:

> The changes to the TargetParser, AsmParser and schedulers are adding new feature support, I think that constitutes one patch and I can split that out.

Yes, from a closer look, I think too that this is a separate patch. Perhaps the only one, indeed, but it was a bit difficult to see :-)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61262/new/

https://reviews.llvm.org/D61262





More information about the llvm-commits mailing list