[PATCH] D56772: [MIR] Add simple PRE pass to MachineCSE

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 30 08:11:39 PDT 2019


RKSimon added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineCSE.cpp:784
+    MachineInstr *MI = &*I;
+    ++I;
+
----------------
anton-afanasyev wrote:
> RKSimon wrote:
> > Very minor - but why can't the ++I be moved inside the for-loop increment statement?
> It can, I'm to fix it, thanks.
This one too?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56772/new/

https://reviews.llvm.org/D56772





More information about the llvm-commits mailing list