[PATCH] D61197: [LLD][ELF] Fix getRankProximity to "ignore" not live sections

Tue Apr 30 03:24:50 PDT 2019

andrewng marked an inline comment as done.
andrewng added inline comments.

================
Comment at: test/ELF/linkerscript/orphan-live-only.s:38
+.section .orphan,"a"
+ .byte 0
----------------
grimar wrote:
> What do you think about adding one more .orphan here with "ax" to show it is placed to a different segment?
> i.e:
> 
> ```
> .section .orphan1,"a"
>  .byte 0
>  
> .section .orphan2,"ax"
>  .byte 0
> ```
I don't mind adding it, although the behaviour of the second orphan is not affected by this patch. However, I guess "no change" can have some value too. I will add it unless someone objects.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61197/new/

https://reviews.llvm.org/D61197