[llvm] r359532 - [DAGCombiner] Do not generate ISD::ADDE node if adde is not legal for the target when combine ISD::TRUNC node

[Zi Xuan Wu via llvm-commits]

Author: wuzish
Date: Mon Apr 29 20:01:14 2019
New Revision: 359532

URL: http://llvm.org/viewvc/llvm-project?rev=359532&view=rev
Log:
[DAGCombiner] Do not generate ISD::ADDE node if adde is not legal for the target when combine ISD::TRUNC node

Do not combine (trunc adde(X, Y, Carry)) into (adde trunc(X), trunc(Y), Carry), 
if adde is not legal for the target. Even it's at type-legalize phase. 
Because adde is special and will not be legalized at operation-legalize phase later.

This fixes: PR40922
https://bugs.llvm.org/show_bug.cgi?id=40922

Differential Revision: https://reviews.llvm.org//D60854

Added:
    llvm/trunk/test/CodeGen/PowerPC/pr40922.ll
Modified:
    llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
    llvm/trunk/test/CodeGen/PowerPC/pr39815.ll

Modified: llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp?rev=359532&r1=359531&r2=359532&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp (original)
+++ llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp Mon Apr 29 20:01:14 2019
@@ -10257,7 +10257,9 @@ SDValue DAGCombiner::visitTRUNCATE(SDNod
   // When the adde's carry is not used.
   if ((N0.getOpcode() == ISD::ADDE || N0.getOpcode() == ISD::ADDCARRY) &&
       N0.hasOneUse() && !N0.getNode()->hasAnyUseOfValue(1) &&
-      (!LegalOperations || TLI.isOperationLegal(N0.getOpcode(), VT))) {
+      // We only do for addcarry before legalize operation
+      ((!LegalOperations && N0.getOpcode() == ISD::ADDCARRY) ||
+       TLI.isOperationLegal(N0.getOpcode(), VT))) {
     SDLoc SL(N);
     auto X = DAG.getNode(ISD::TRUNCATE, SL, VT, N0.getOperand(0));
     auto Y = DAG.getNode(ISD::TRUNCATE, SL, VT, N0.getOperand(1));

Modified: llvm/trunk/test/CodeGen/PowerPC/pr39815.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/PowerPC/pr39815.ll?rev=359532&r1=359531&r2=359532&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/PowerPC/pr39815.ll (original)
+++ llvm/trunk/test/CodeGen/PowerPC/pr39815.ll Mon Apr 29 20:01:14 2019
@@ -20,10 +20,9 @@ entry:
 ; CHECK:      # %bb.0:
 ; CHECK-DAG:   addis [[REG1:[0-9]+]], [[REG2:[0-9]+]], [[VAR1:[a-z0-9A-Z_.]+]]@toc at ha
 ; CHECK-DAG:   ld [[REG3:[0-9]+]], [[VAR1]]@toc at l([[REG1]])
-; CHECK-DAG:   lbz [[REG4:[0-9]+]], 0([[REG3]])
+; CHECK-DAG:   lwz [[REG4:[0-9]+]], 0([[REG3]])
 ; CHECK-DAG:   addic [[REG5:[0-9]+]], [[REG3]], -1
-; CHECK-DAG:   extsb [[REG6:[0-9]+]], [[REG4]]
-; CHECK-DAG:   addze [[REG7:[0-9]+]], [[REG6]]
+; CHECK-DAG:   addze [[REG7:[0-9]+]], [[REG4]]
 ; CHECK-DAG:   addis [[REG8:[0-9]+]], [[REG2]], [[VAR2:[a-z0-9A-Z_.]+]]@toc at ha
 ; CHECK-DAG:   andi. [[REG9:[0-9]+]], [[REG7]], 5
 ; CHECK-DAG:   stb [[REG9]], [[VAR2]]@toc at l([[REG8]])

Added: llvm/trunk/test/CodeGen/PowerPC/pr40922.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/PowerPC/pr40922.ll?rev=359532&view=auto
==============================================================================
--- llvm/trunk/test/CodeGen/PowerPC/pr40922.ll (added)
+++ llvm/trunk/test/CodeGen/PowerPC/pr40922.ll Mon Apr 29 20:01:14 2019
@@ -0,0 +1,36 @@
+; RUN: llc -verify-machineinstrs -mtriple=powerpc-unknown-linux-gnu < %s | FileCheck %s
+
+; Test case adapted from PR40922.
+
+ at a.b = internal global i32 0, align 4
+
+define i32 @a() {
+entry:
+  %call = tail call i32 bitcast (i32 (...)* @d to i32 ()*)()
+  %0 = load i32, i32* @a.b, align 4
+  %conv = zext i32 %0 to i64
+  %add = add nuw nsw i64 %conv, 6
+  %and = and i64 %add, 8589934575
+  %cmp = icmp ult i64 %and, %conv
+  br i1 %cmp, label %if.then, label %if.end
+
+if.then:                                          ; preds = %entry
+  %call3 = tail call i32 bitcast (i32 (...)* @e to i32 ()*)()
+  br label %if.end
+
+if.end:                                           ; preds = %if.then, %entry
+  store i32 %call, i32* @a.b, align 4
+  ret i32 undef
+}
+
+; CHECK-LABEL: @a
+; CHECK: li 5, 0
+; CHECK: mr 30, 3
+; CHECK: addic 6, 4, 6
+; CHECK: addze 5, 5
+; CHECK: rlwinm 6, 6, 0, 28, 26
+; CHECK: andi. 5, 5, 1
+
+declare i32 @d(...)
+
+declare i32 @e(...)