[PATCH] D61289: [globalisel] Add G_SEXT_INREG

Daniel Sanders via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 29 17:31:43 PDT 2019


dsanders marked an inline comment as done.
dsanders added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/artifact-combiner-sext.mir:64-68
+    ; CHECK-DAG: [[TRUNC:%[0-9]+]]:_(<2 x s16>) = G_TRUNC [[COPY]](<2 x s32>)
+    ; The G_SEXT_INREG doesn't lower here because G_TRUNC is both illegal and
+    ; unable to legalize. This prevents further legalization.
+    ; CHECK-DAG: [[SEXT_INREG:%[0-9]+]]:_(<2 x s16>) = G_SEXT_INREG [[TRUNC]], 8
+    ; CHECK-DAG: $vgpr0 = COPY [[SEXT_INREG]](<2 x s16>)
----------------
@arsenm: This test currently doesn't complete legalization because the pre-existing G_TRUNC causes the legalizer to stop processing since it's illegal and it's unable to legalize it. This blocks the lowering of the G_SEXT_INREG which appears later in the work list.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61289/new/

https://reviews.llvm.org/D61289





More information about the llvm-commits mailing list