[PATCH] D61105: [MS] Emit S_HEAPALLOCSITE debug info in SelectionDAG

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 29 16:44:35 PDT 2019


rnk added subscribers: efriedma, bogner.
rnk added a comment.

+ at efriedma @bogner Is this SDNode map a good idea? It was the least invasive way we could think of to pass the call site markers down to the MachineInstr.

IIRC @bogner you ran into issues with SDNode replacement and reuse. Is this map keyed by SDNode reasonable, or are we asking for ABA problems? Apologies if I'm misremembering where I heard this story.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61105/new/

https://reviews.llvm.org/D61105





More information about the llvm-commits mailing list