[PATCH] D61277: [PDB] Fix hash function used to write /src/headerblock

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 29 13:20:56 PDT 2019


rnk accepted this revision.
rnk added a comment.

lgtm

Initially I thought "we should change the return type of `pdb::hashStringV1`, but after studying the pdb code more, I see that sometimes the full 32-bit string hash is used, and sometimes only the 16-bit hash is used. I guess we just have to be careful and truncate wherever it seems necessary.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61277/new/

https://reviews.llvm.org/D61277





More information about the llvm-commits mailing list