[PATCH] D60348: [COFF, ARM64] Fix ABI implementation of struct returns

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 29 12:10:00 PDT 2019


efriedma added inline comments.


================
Comment at: lib/Target/AArch64/AArch64ISelLowering.cpp:3420
   bool CCMatch = CallerCC == CalleeCC;
+  const Triple &TT = getTargetMachine().getTargetTriple();
 
----------------
Unnecessary change.


================
Comment at: test/CodeGen/AArch64/arm64-windows-returns.ll:72
+; Function Attrs: noinline nounwind optnone uwtable
+define dso_local void @"?inst at C"(%class.C* %this, %class.A* inreg noalias sret %agg.result) #0 align 2 {
+entry:
----------------
Please add a testcase for a non-instance method, where the first argument is inreg.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60348/new/

https://reviews.llvm.org/D60348





More information about the llvm-commits mailing list