[PATCH] D60980: [libFuzzer] Replace -seed_corpus to better support fork mode on Win

[Kostya Serebryany via Phabricator via llvm-commits]

kcc added inline comments.


================
Comment at: compiler-rt/lib/fuzzer/FuzzerFlags.def:23
   "size up to max_len.")
-FUZZER_FLAG_STRING(seed_inputs, "A comma-separated list of input files "
-  "to use as an additional seed corpus")
+FUZZER_FLAG_STRING(seed_inputs_file, "A file containing a comma-separated list "
+  "of input files to use as an additional seed corpus.")
----------------
metzman wrote:
> kcc wrote:
> > I found this flag to be useful by itself, outside the fork mode, so instead of replacing it with a new flag, 
> > I'd suggest enhancing it's behavior: 
> >   * --seed_inputs=aaa,bbb keeps working as is
> >   * --seed_inputs=@file_path reads the list from the file
> So that "@" will be necessary to distinguish between a case where we want to use one seed and a case where we want to use the file as the seed list?
Yes. 
W/o @ the current behavior is preserved: the argument is a comma-separated list of seeds. 
W/ @ the argument (with @ stripped) will be treated as a file name, which contains the comma-separated list of seeds


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60980/new/

https://reviews.llvm.org/D60980