[PATCH] D60831: [DebugInfo at O2][LoopVectorize] pr39024: Vectorized code linenos step through loop even after completion

[Hal Finkel via Phabricator via llvm-commits]

hfinkel added a comment.

In D60831#1482390 <https://reviews.llvm.org/D60831#1482390>, @Orlando wrote:

> Ping.
>
> A summary of the discussion so far:
>
> The middle block is quite "latch like" in that it dictates control flow between the vectorized and scalar loops, but it can contain additional
>  instructions. For example, it may also handle converting the vectorized results into a scalar value.
>
> The patch maps all middle block instructions to the line of the loop latch branch.
>
> An initial question of "How much will this affect profiling tools that rely on this debug info?" was not fully addressed because
>  discussions on an alternative solution I mentioned eclipsed the original question.


My take-away from the discussion was this: It is desirable to map the instructions to something in the loop (e.g., not line 0), unless doing so will provide confusing information to the mapping that PGO uses to optimize the relevant branches. Am I correct in saying that this latter issue is of minimal concern in this case?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60831/new/

https://reviews.llvm.org/D60831