[PATCH] D61186: [LLD][ELF] /DISCARD/ output sections should not be orphans

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 29 07:00:10 PDT 2019


grimar added a comment.

In D61186#1482391 <https://reviews.llvm.org/D61186#1482391>, @andrewng wrote:

> In D61186#1482350 <https://reviews.llvm.org/D61186#1482350>, @grimar wrote:
>
> > I am still not sure we should not just remove the `/DISCARD/` like D61251 <https://reviews.llvm.org/D61251> did (your explanation makes sense to me, though).
>
>
> I agree that it would be nice to ensure that '/DISCARD/' it not output, but the focus of this patch is to fix the undesirable side-effects of the current handling of '/DISCARD/'.


Yes, I understand. And I think we probably can go with it (if other people have no objectons about leaving it in the output, at least for now).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61186/new/

https://reviews.llvm.org/D61186





More information about the llvm-commits mailing list